feat: register Android push service in manifest and wire into plugin#384
Open
Rosie-Kennelly-1 wants to merge 1 commit intorosie/android-expo-push-kotlin-generationfrom
Open
Conversation
…nto plugin pipeline Adds manifest registration for the generated service with priority 10 and android:exported=false. Detects existing FCM services and warns instead of conflicting. Wires the Android plugin into the push notification pipeline alongside the existing iOS plugins. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
towards: https://github.com/intercom/intercom/issues/360467
The generated
FirebaseMessagingServicefrom the previous PR needs to be registered inAndroidManifest.xmlfor Android to route FCM events to it, and wired into the existing Expo push notification plugin pipeline.How?
Adds manifest registration with
android:priority="10"andandroid:exported="false", detects existing FCM services to avoid conflicts, and chains the Android plugin intowithPushNotifications.tsalongside the existing iOS plugins.Part 2 of 2. Stacked on:
Related:
Generated with Claude Code